[
https://issues.apache.org/jira/browse/BEAM-8382?focusedWorklogId=327914&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-327914
]
ASF GitHub Bot logged work on BEAM-8382:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Oct/19 15:38
Start Date: 14/Oct/19 15:38
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on issue #9765: [BEAM-8382]
Add polling interval to KinesisIO.Read
URL: https://github.com/apache/beam/pull/9765#issuecomment-541746270
@jfarr I guess it would not complicate things too much. My idea is the
following - when we fetch new records in `ShardReadersPool.readLoop()` with
`shardRecordsIterator.readNextBatch()` then it will finally end up in calling
`SimplifiedKinesisClient.getRecords()` where we execute
`AmazonKinesis.getRecords()` and wrap exceptions, if any. So, it looks like
that we can re-throw `KMSThrottlingException` and catch it in
`ShardReadersPool.readLoop()`. In case of this exception we can write warning
in logs about that, wait with progressive timeout (starting from 1 second) and
recall `shardRecordsIterator.readNextBatch()` again. In this case no additional
knobs well be needed.
I'm a bit sceptical about user-defined config option in this case since we
usually never know which value will be optimal and sufficient.
Wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 327914)
Time Spent: 50m (was: 40m)
> Add polling interval to KinesisIO.Read
> --------------------------------------
>
> Key: BEAM-8382
> URL: https://issues.apache.org/jira/browse/BEAM-8382
> Project: Beam
> Issue Type: Improvement
> Components: io-java-kinesis
> Affects Versions: 2.13.0, 2.14.0, 2.15.0
> Reporter: Jonothan Farr
> Assignee: Jonothan Farr
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> With the current implementation we are observing Kinesis throttling due to
> ReadProvisionedThroughputExceeded on the order of hundreds of times per
> second, regardless of the actual Kinesis throughput. This is because the
> ShardReadersPool readLoop() method is polling getRecords() as fast as
> possible.
> From the KDS documentation:
> {quote}Each shard can support up to five read transactions per second.
> {quote}
> and
> {quote}For best results, sleep for at least 1 second (1,000 milliseconds)
> between calls to getRecords to avoid exceeding the limit on getRecords
> frequency.
> {quote}
> [https://docs.aws.amazon.com/streams/latest/dev/service-sizes-and-limits.html]
> [https://docs.aws.amazon.com/streams/latest/dev/developing-consumers-with-sdk.html]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
