[ 
https://issues.apache.org/jira/browse/BEAM-8372?focusedWorklogId=328131&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-328131
 ]

ASF GitHub Bot logged work on BEAM-8372:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Oct/19 20:47
            Start Date: 14/Oct/19 20:47
    Worklog Time Spent: 10m 
      Work Description: ibzib commented on pull request #9775: [BEAM-8372] Job 
server submitting UberJars directly to Flink Runner.
URL: https://github.com/apache/beam/pull/9775#discussion_r334652926
 
 

 ##########
 File path: sdks/python/apache_beam/runners/portability/artifact_service.py
 ##########
 @@ -23,51 +23,61 @@
 from __future__ import print_function
 
 import hashlib
-import random
-import re
+import threading
+import zipfile
+
+from google.protobuf import json_format
 
 from apache_beam.io import filesystems
 from apache_beam.portability.api import beam_artifact_api_pb2
 from apache_beam.portability.api import beam_artifact_api_pb2_grpc
 
 
-class BeamFilesystemArtifactService(
+class AbstractArtifactService(
     beam_artifact_api_pb2_grpc.ArtifactStagingServiceServicer,
     beam_artifact_api_pb2_grpc.ArtifactRetrievalServiceServicer):
 
   _DEFAULT_CHUNK_SIZE = 2 << 20  # 2mb
 
-  def __init__(self, root, chunk_size=_DEFAULT_CHUNK_SIZE):
+  def __init__(self, root, chunk_size=None):
 
 Review comment:
   Missed that, makes sense.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 328131)
    Time Spent: 2h  (was: 1h 50m)

> Allow submission of Flink UberJar directly to flink cluster.
> ------------------------------------------------------------
>
>                 Key: BEAM-8372
>                 URL: https://issues.apache.org/jira/browse/BEAM-8372
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-py-core
>            Reporter: Robert Bradshaw
>            Assignee: Robert Bradshaw
>            Priority: Major
>          Time Spent: 2h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to