[
https://issues.apache.org/jira/browse/BEAM-8348?focusedWorklogId=328135&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-328135
]
ASF GitHub Bot logged work on BEAM-8348:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Oct/19 20:52
Start Date: 14/Oct/19 20:52
Worklog Time Spent: 10m
Work Description: tweise commented on pull request #9789: [BEAM-8348] set
job_name in portable_runner.py
URL: https://github.com/apache/beam/pull/9789#discussion_r334657707
##########
File path: sdks/python/apache_beam/runners/portability/portable_runner.py
##########
@@ -296,7 +297,8 @@ def add_runner_options(parser):
prepare_response = job_service.Prepare(
beam_job_api_pb2.PrepareJobRequest(
- job_name='job', pipeline=proto_pipeline,
+ job_name=options.view_as(GoogleCloudOptions).job_name or 'job',
Review comment:
GoogleCloudOptions doesn't seem appropriate for this. Should we relocate the
option?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 328135)
Time Spent: 1h 20m (was: 1h 10m)
> Portable Python job name hard-coded to "job"
> --------------------------------------------
>
> Key: BEAM-8348
> URL: https://issues.apache.org/jira/browse/BEAM-8348
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: Minor
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> See [1]. `job_name` is already taken by Google Cloud options [2], so I guess
> we should create a new option (maybe `portable_job_name` to avoid disruption).
> [[1]
> https://github.com/apache/beam/blob/55588e91ed8e3e25bb661a6202c31e99297e0e79/sdks/python/apache_beam/runners/portability/portable_runner.py#L294|https://github.com/apache/beam/blob/55588e91ed8e3e25bb661a6202c31e99297e0e79/sdks/python/apache_beam/runners/portability/portable_runner.py#L294]
> [2]
> [https://github.com/apache/beam/blob/c5bbb51014f7506a2651d6070f27fb3c3dc0da8f/sdks/python/apache_beam/options/pipeline_options.py#L438]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
