[
https://issues.apache.org/jira/browse/BEAM-8365?focusedWorklogId=328830&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-328830
]
ASF GitHub Bot logged work on BEAM-8365:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Oct/19 23:15
Start Date: 15/Oct/19 23:15
Worklog Time Spent: 10m
Work Description: 11moon11 commented on pull request #9764: [BEAM-8365]
Project push-down for TestTableProvider
URL: https://github.com/apache/beam/pull/9764#discussion_r335217355
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/test/TestTableProvider.java
##########
@@ -157,16 +169,18 @@ public BeamTableStatistics
getTableStatistics(PipelineOptions options) {
public PCollection<Row> buildIOReader(
PBegin begin, BeamSqlTableFilter filters, List<String> fieldNames) {
PCollection<Row> withAllFields = buildIOReader(begin);
- if (fieldNames.isEmpty() && filters instanceof DefaultTableFilter) {
+ if (options == PushDownOptions.NONE) { // needed for testing purposes
return withAllFields;
}
Review comment:
Added checks that throw a `RuntimeException` when an invalid scenario is
encountered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 328830)
Time Spent: 5h 40m (was: 5.5h)
> Add project push-down capability to IO APIs
> -------------------------------------------
>
> Key: BEAM-8365
> URL: https://issues.apache.org/jira/browse/BEAM-8365
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Kirill Kozlov
> Assignee: Kirill Kozlov
> Priority: Major
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
> * InMemoryTable should implement a following method:
> {code:java}
> public PCollection<Row> buildIOReader(
> PBegin begin, BeamSqlTableFilter filters, List<String> fieldNames);{code}
> Which should return a `PCollection` with fields specified in `fieldNames`
> list.
> * Create a rule to push fields used by a Calc (in projects and in a
> condition) down into TestTable IO.
> * Updating that same Calc (from previous step) to have a proper input and
> output schemes, remove unused fields.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
