[
https://issues.apache.org/jira/browse/BEAM-8350?focusedWorklogId=329273&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-329273
]
ASF GitHub Bot logged work on BEAM-8350:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Oct/19 17:18
Start Date: 16/Oct/19 17:18
Worklog Time Spent: 10m
Work Description: tvalentyn commented on issue #9725: [BEAM-8350] Upgrade
to Pylint 2.4
URL: https://github.com/apache/beam/pull/9725#issuecomment-542803906
LGTM, thank you.
We can merge after tests pass.
I can file remaining Jiras.
> I think we should exclude this, because mypy is much better at determining
structural problems,
and it will catch this kind of thing with far fewer false positives.
Sounds good. We can certainly use mypy if that's the case. I would be
conservative with excluding the rules unless:
- We have frequent false-positives for a rule.
- We have checked that mypy catches the errors of this kind.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 329273)
Time Spent: 7h 40m (was: 7.5h)
> Upgrade to pylint 2.4
> ---------------------
>
> Key: BEAM-8350
> URL: https://issues.apache.org/jira/browse/BEAM-8350
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 7h 40m
> Remaining Estimate: 0h
>
> pylint 2.4 provides a number of new features and fixes, but the most
> important/pressing one for me is that 2.4 adds support for understanding
> python type annotations, which fixes a bunch of spurious unused import errors
> in the PR I'm working on for BEAM-7746.
> As of 2.0, pylint dropped support for running tests in python2, so to make
> the upgrade we have to move our lint jobs to python3. Doing so will put
> pylint into "python3-mode" and there is not an option to run in
> python2-compatible mode. That said, the beam code is intended to be python3
> compatible, so in practice, performing a python3 lint on the Beam code-base
> is perfectly safe. The primary risk of doing this is that someone introduces
> a python-3 only change that breaks python2, but these would largely be syntax
> errors that would be immediately caught by the unit and integration tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
