[
https://issues.apache.org/jira/browse/BEAM-8374?focusedWorklogId=329637&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-329637
]
ASF GitHub Bot logged work on BEAM-8374:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Oct/19 06:39
Start Date: 17/Oct/19 06:39
Worklog Time Spent: 10m
Work Description: jfarr commented on issue #9758: [BEAM-8374] Fixes bug
in SnsIO PublishResultCoder
URL: https://github.com/apache/beam/pull/9758#issuecomment-543029226
> One extra issue that I have not really thought about is the size
difference that we will have by adding the full headers/sdk metadata to all
answers, mmm... now I am hesitating about maybe having a `V2` like approach for
the cases where we care about the full metadata (akin to FileIO).
> What is the use case that is pushing into this approach?
@iemejia for our use case we only need the HTTP status. We have written an
SNS sink that uses this to check for error responses. I just included HTTP
headers for completeness but I can remove them if it's a concern. In that case
I wonder if a separate coder for SdkHttpMetadata makes sense though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 329637)
Time Spent: 1.5h (was: 1h 20m)
> PublishResult returned by SnsIO is missing sdkResponseMetadata and
> sdkHttpMetadata
> ----------------------------------------------------------------------------------
>
> Key: BEAM-8374
> URL: https://issues.apache.org/jira/browse/BEAM-8374
> Project: Beam
> Issue Type: Bug
> Components: io-java-aws
> Affects Versions: 2.13.0, 2.14.0, 2.15.0
> Reporter: Jonothan Farr
> Assignee: Jonothan Farr
> Priority: Minor
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Currently the PublishResultCoder in SnsIO only serializes the messageId field
> so the PublishResult returned by Beam returns null for
> getSdkResponseMetadata() and getSdkHttpMetadata(). This makes it impossible
> to check the HTTP status for errors, which is necessary since this is not
> handled in SnsIO.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
