[
https://issues.apache.org/jira/browse/BEAM-8417?focusedWorklogId=329726&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-329726
]
ASF GitHub Bot logged work on BEAM-8417:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Oct/19 10:03
Start Date: 17/Oct/19 10:03
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #9814: [BEAM-8417] Expose
ExternalWorkerHandler hostname
URL: https://github.com/apache/beam/pull/9814#discussion_r335917215
##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner.py
##########
@@ -1365,6 +1365,10 @@ def start_worker(self):
def stop_worker(self):
pass
+ def localhost_from_worker(self):
Review comment:
Could we rename this method here and elsewhere?
```suggestion
def host_from_worker(self):
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 329726)
Time Spent: 50m (was: 40m)
> Expose ExternalWorkerHandler hostname
> -------------------------------------
>
> Key: BEAM-8417
> URL: https://issues.apache.org/jira/browse/BEAM-8417
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Wanqi Lyu
> Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently `fn_api_runner.ExternalWorkerHandler` endpoints have `localhost` as
> their hostname by default, which prevents it from being connected from
> external workers started on other machines.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
