[ 
https://issues.apache.org/jira/browse/BEAM-8410?focusedWorklogId=329928&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-329928
 ]

ASF GitHub Bot logged work on BEAM-8410:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Oct/19 15:15
            Start Date: 17/Oct/19 15:15
    Worklog Time Spent: 10m 
      Work Description: cmachgodaddy commented on issue #9808: [BEAM-8410] 
JdbcIO should support setConnectionInitSqls in its DataSource
URL: https://github.com/apache/beam/pull/9808#issuecomment-543223487
 
 
   @aromanenko-dev , I added unit test for fail case (who don't use Maria or 
MySql). But I think we shouldn't add test for success case (use MySQL or 
Maria), otherwise, we have to bing in a my mysql/maria jar package. Beside, 
this property `withConnectionInitSqls` is very similar to the property 
`withConnectionProperties` , which doesn't have any unit tests. Let me know 
what you think?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 329928)
    Time Spent: 40m  (was: 0.5h)

> JdbcIO should support setConnectionInitSqls in its DataSource
> -------------------------------------------------------------
>
>                 Key: BEAM-8410
>                 URL: https://issues.apache.org/jira/browse/BEAM-8410
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-jdbc
>            Reporter: Cam Mach
>            Assignee: Cam Mach
>            Priority: Minor
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> This property, connectionInitSqls, is very handy for anyone who use MySql and 
> Mariadb, to set any init sql statements to be executed at connection time. 
> Note: but it's not applicable across databases



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to