[
https://issues.apache.org/jira/browse/BEAM-8429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954175#comment-16954175
]
Alex Amato commented on BEAM-8429:
----------------------------------
>From an ease of use/UX perspective, its not self evident to me if we should
>force all runners to expose an API for their system metrics. I recommend
>making it optional for each runner to decide. Runners already decide whether
>or not they consume MonitoringInfos exposed by SDK Harnesses.
For instance in Dataflow, we may prefer that you ingest these with Stackdriver,
and only use System metrics to populate stackdriver metrics, the DF UI, etc.
> Define API for getting non user metrics.
> ----------------------------------------
>
> Key: BEAM-8429
> URL: https://issues.apache.org/jira/browse/BEAM-8429
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core, sdk-py-core
> Reporter: Ahmet Altay
> Priority: Major
>
> MetricResults API does not support a way to query system metrics. Different
> implementations accomplish the same thing in different ways.
> FnApiRunner has a monitoring_metrics() defined on its PipelineResult
> (RunnerResult) object.
> DataflowRunner, has a all_metrics() method defined on its MetricResults
> (DataflowMetrics) object.
> Dataflow implementation of using metrics().all_metrics() sound reasonable. It
> would be usefult to define a single API that all runners implementations
> could agree on.
> cc: [~pabloem] [~robertwb] [~Ardagan]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
