[
https://issues.apache.org/jira/browse/BEAM-8445?focusedWorklogId=331562&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-331562
]
ASF GitHub Bot logged work on BEAM-8445:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Oct/19 18:13
Start Date: 21/Oct/19 18:13
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #9837:
[BEAM-8445] Fix some not allowed nulls in ZetaSQL translator
URL: https://github.com/apache/beam/pull/9837#discussion_r337164659
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLPlannerImpl.java
##########
@@ -98,27 +98,42 @@ public ZetaSQLPlannerImpl(FrameworkConfig config) {
@Override
public SqlNode parse(String s) throws SqlParseException {
- return null;
+ throw new UnsupportedOperationException(
+ String.format(
+ "%s.parse(String) is not implemented and should need be called",
Review comment:
Ah "should _not_ need to be called". But yes, it can be simplified. My
intent was to signal to the client that this is a class with a bunch of extra
methods most of which are not needed for the functionality it delivers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 331562)
Remaining Estimate: 0h
Time Spent: 10m
> ZetaSQL translator returns null from unsupported methods
> --------------------------------------------------------
>
> Key: BEAM-8445
> URL: https://issues.apache.org/jira/browse/BEAM-8445
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql-zetasql
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This is an error-prone style that was missed because our null analysis is
> disabled.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
