[
https://issues.apache.org/jira/browse/BEAM-8372?focusedWorklogId=334510&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-334510
]
ASF GitHub Bot logged work on BEAM-8372:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Oct/19 10:07
Start Date: 26/Oct/19 10:07
Worklog Time Spent: 10m
Work Description: mxm commented on issue #9844: [BEAM-8372] Support both
flink_master and flink_master_url parameter
URL: https://github.com/apache/beam/pull/9844#issuecomment-546589217
>I guess it's `--flink_master` that's new (in Python's FlinkRunner).
This option since the inception of the Flink Runner was `flinkMaster` (Java)
or `flink_master` (Python):
https://github.com/apache/beam/blob/8972e5e10050b67a4a9a0027c09d2d2eb00b45ed/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkPipelineOptions.java#L66
https://github.com/apache/beam/blob/50528d024b83a5083afa24bd7c3e3694a6347c15/sdks/python/apache_beam/options/pipeline_options.py#L669
In the light of URLs not even being supported, it also makes sense to keep
that name instead of renaming it to `flink_master_url`.
> But if we don't have the http than we need to change the
https://github.com/apache/beam/pull/9775 to add it.
Could there be a misunderstanding? Rest does not mean that we need to
prepend `http://`. The format is `host:port` where host is a hostname or a
IPv4/IPv6 address, and port is the port number, i.e. of Flink's Rest service
(typically running at port 8081). Please correct me, but I don't see that we
need to change #9775.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 334510)
Time Spent: 7h 10m (was: 7h)
> Allow submission of Flink UberJar directly to flink cluster.
> ------------------------------------------------------------
>
> Key: BEAM-8372
> URL: https://issues.apache.org/jira/browse/BEAM-8372
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
> Priority: Major
> Time Spent: 7h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
