[
https://issues.apache.org/jira/browse/BEAM-8507?focusedWorklogId=335586&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-335586
]
ASF GitHub Bot logged work on BEAM-8507:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Oct/19 16:07
Start Date: 29/Oct/19 16:07
Worklog Time Spent: 10m
Work Description: tweise commented on pull request #9918: [BEAM-8507] Fix
'flink_master' parameter for the upcoming release
URL: https://github.com/apache/beam/pull/9918#discussion_r340173792
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkJobInvoker.java
##########
@@ -66,7 +66,9 @@ protected JobInvocation invokeWithExecutor(
String.format("%s_%s", flinkOptions.getJobName(),
UUID.randomUUID().toString());
if (FlinkPipelineOptions.AUTO.equals(flinkOptions.getFlinkMaster())) {
- flinkOptions.setFlinkMaster(serverConfig.getFlinkMaster());
+ // Although Flink uses Rest, it expects the address not to contain a
http scheme
+ String flinkMaster =
serverConfig.getFlinkMaster().trim().replaceFirst("^http://";, "");
Review comment:
That support can be added to the client independently and should not require
to revisit this again. Someone else could write a different client that
supports https or use a proxy that doesn't require extra config. Why make
unnecessary assumptions about the client.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 335586)
Time Spent: 1h 10m (was: 1h)
> Unspecified flink_master fails on Python 3.6+
> ---------------------------------------------
>
> Key: BEAM-8507
> URL: https://issues.apache.org/jira/browse/BEAM-8507
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Kyle Weaver
> Priority: Major
> Fix For: 2.17.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> [auto] was made the default flink_master in
> [https://github.com/apache/beam/pull/9844]. Since FlinkUberJarJobServer does
> not support [auto], this is a problem for Python 3.6 and 3.7. (It is fine for
> 3.5 because 3.5 does not use FlinkUberJarJobServer.)
>
> requests.exceptions.InvalidURL: Failed to parse: [auto]/v1/config
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
