[
https://issues.apache.org/jira/browse/BEAM-8540?focusedWorklogId=337382&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337382
]
ASF GitHub Bot logged work on BEAM-8540:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Nov/19 15:45
Start Date: 01/Nov/19 15:45
Worklog Time Spent: 10m
Work Description: jbonofre commented on pull request #9964: [BEAM-8540]
Fix CSVSink example in FileIO docs
URL: https://github.com/apache/beam/pull/9964#discussion_r341631480
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileIO.java
##########
@@ -262,21 +262,21 @@
* writer.println(Joiner.on(",").join(element));
* }
*
- * public void finish() throws IOException {
+ * public void flush() throws IOException {
* writer.flush();
* }
* }
*
* PCollection<BankTransaction> transactions = ...;
* // Convert transactions to strings before writing them to the CSV sink.
* transactions.apply(MapElements
- * .into(lists(strings()))
+ * .into(TypeDescriptors.lists(TypeDescriptors.strings()))
Review comment:
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 337382)
Time Spent: 40m (was: 0.5h)
> Fix CSVSink example in FileIO docs
> ----------------------------------
>
> Key: BEAM-8540
> URL: https://issues.apache.org/jira/browse/BEAM-8540
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Jeff Klukas
> Assignee: Jeff Klukas
> Priority: Trivial
> Fix For: 2.18.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The CSVSink example in the FileIO docs contains some syntax errors and looks
> out of date. We should get that working again.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
