[
https://issues.apache.org/jira/browse/BEAM-8254?focusedWorklogId=337630&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337630
]
ASF GitHub Bot logged work on BEAM-8254:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Nov/19 00:39
Start Date: 02/Nov/19 00:39
Worklog Time Spent: 10m
Work Description: aaltay commented on pull request #9961: [BEAM-8254] add
workerRegion and workerZone options to Java SDK
URL: https://github.com/apache/beam/pull/9961#discussion_r341790434
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##########
@@ -357,6 +361,36 @@ public static DataflowRunner fromOptions(PipelineOptions
options) {
return new DataflowRunner(dataflowOptions);
}
+ @VisibleForTesting
+ static void validateWorkerSettings(GcpOptions gcpOptions) {
+ Preconditions.checkArgument(
+ gcpOptions.getZone() == null || gcpOptions.getWorkerRegion() == null,
+ "Cannot use option zone with workerRegion.");
Review comment:
"Cannot use option zone with workerRegion." -> "Cannot use option zone with
workerRegion. Prefer workerRegion and workerZone." ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 337630)
Time Spent: 20m (was: 10m)
> (Java SDK) Add workerRegion and workerZone options
> --------------------------------------------------
>
> Key: BEAM-8254
> URL: https://issues.apache.org/jira/browse/BEAM-8254
> Project: Beam
> Issue Type: Sub-task
> Components: runner-dataflow, sdk-java-core
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
