[
https://issues.apache.org/jira/browse/BEAM-7948?focusedWorklogId=338021&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-338021
]
ASF GitHub Bot logged work on BEAM-7948:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Nov/19 08:12
Start Date: 04/Nov/19 08:12
Worklog Time Spent: 10m
Work Description: sunjincheng121 commented on issue #9949: [BEAM-7948]
Add time-based cache threshold support in the Java data s…
URL: https://github.com/apache/beam/pull/9949#issuecomment-549254811
@lukecwik Thanks a lot for your review. I have updated the PR and addressed
your comments.
> I was wondering how this manifests?
>
> Do you have a way to cancel downstream computations based upon the output
of this bundle if this bundle fails?
If a bundle fails, the exception will be prograted to the main thread at the
next time when an input element is processed(accept/close is called). So I
think the failure handle logic for time-based data buffer strategy is the same
as the size-based data buffer strategy. Time-based data buffer strategy has not
and also should not introduce extra complexity for failure handling.
Looking forward to your feedback.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 338021)
Time Spent: 40m (was: 0.5h)
> Add time-based cache threshold support in the Java data service
> ---------------------------------------------------------------
>
> Key: BEAM-7948
> URL: https://issues.apache.org/jira/browse/BEAM-7948
> Project: Beam
> Issue Type: Sub-task
> Components: java-fn-execution
> Reporter: sunjincheng
> Assignee: sunjincheng
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently only size-based cache threshold is supported in data service. It
> should also support the time-based cache threshold. This is very important,
> especially for streaming jobs which are sensitive to the delay.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)