[
https://issues.apache.org/jira/browse/BEAM-7013?focusedWorklogId=338241&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-338241
]
ASF GitHub Bot logged work on BEAM-7013:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Nov/19 17:44
Start Date: 04/Nov/19 17:44
Worklog Time Spent: 10m
Work Description: zfraa commented on pull request #9778: [BEAM-7013]
Update BigQueryHllSketchCompatibilityIT to cover empty sketch cases
URL: https://github.com/apache/beam/pull/9778#discussion_r342170633
##########
File path:
sdks/java/extensions/zetasketch/src/main/java/org/apache/beam/sdk/extensions/zetasketch/HllCount.java
##########
@@ -107,6 +109,20 @@
// Cannot be instantiated. This class is intended to be a namespace only.
private HllCount() {}
+ /**
+ * Returns the sketch stored as bytes in the input {@code ByteBuffer}. If
the input {@code
Review comment:
Was confused here at first (when not being aware that this is a static
method, one can read it as "the user passes in an empty/reusable ByteBuffer and
the library returns the serialized sketch in that ByteBuffer").
To avoid that not-so-alert readers think that ;), how about
"Converts the passed-in sketch from ByteBuffer to byte[], mapping null
ByteBuffers (representing empty sketches) to empty byte[]. Utility method to
convert sketches materialized with ZetaSQL/BigQuery to valid input for HllCount
transforms."?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 338241)
Time Spent: 36.5h (was: 36h 20m)
> A new count distinct transform based on BigQuery compatible HyperLogLog++
> implementation
> ----------------------------------------------------------------------------------------
>
> Key: BEAM-7013
> URL: https://issues.apache.org/jira/browse/BEAM-7013
> Project: Beam
> Issue Type: New Feature
> Components: extensions-java-sketching, sdk-java-core
> Reporter: Yueyang Qiu
> Assignee: Yueyang Qiu
> Priority: Major
> Fix For: 2.16.0
>
> Time Spent: 36.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
