[ 
https://issues.apache.org/jira/browse/BEAM-8532?focusedWorklogId=338366&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-338366
 ]

ASF GitHub Bot logged work on BEAM-8532:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Nov/19 21:49
            Start Date: 04/Nov/19 21:49
    Worklog Time Spent: 10m 
      Work Description: robertwb commented on pull request #9958: [BEAM-8532] 
Output timestamp should be the inclusive, not exclusive, end of window.
URL: https://github.com/apache/beam/pull/9958
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 338366)
    Time Spent: 40m  (was: 0.5h)

> Beam Python trigger driver sets incorrect timestamp for output windows.
> -----------------------------------------------------------------------
>
>                 Key: BEAM-8532
>                 URL: https://issues.apache.org/jira/browse/BEAM-8532
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Robert Bradshaw
>            Assignee: Robert Bradshaw
>            Priority: Critical
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> The timestamp should lie in the window, otherwise re-windowing will not be 
> idempotent. 
> https://github.com/apache/beam/blob/release-2.16.0/sdks/python/apache_beam/transforms/trigger.py#L1183
>  should be using {{window.max_timestamp()}} rather than {{.end}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to