[
https://issues.apache.org/jira/browse/BEAM-8523?focusedWorklogId=338860&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-338860
]
ASF GitHub Bot logged work on BEAM-8523:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Nov/19 16:48
Start Date: 05/Nov/19 16:48
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9959: WIP:
[BEAM-8523] JobAPI: Give access to timestamped state change history
URL: https://github.com/apache/beam/pull/9959#discussion_r342669884
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/jobsubmission/JobStateEvent.java
##########
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.runners.fnexecution.jobsubmission;
+
+import com.google.auto.value.AutoValue;
+import java.time.Instant;
+import org.apache.beam.model.jobmanagement.v1.JobApi;
+import org.apache.beam.vendor.grpc.v1p21p0.com.google.protobuf.Timestamp;
+
+/** A state transition event. */
+@AutoValue
+public abstract class JobStateEvent {
Review comment:
The usage of wrapper classes was primarily because grpc/proto was an
annoying dependency until we were able to vendor it and also to not expose
proto/grpc on the API surface. Since this isn't on the SDK's public API surface
and an internal implementation detail, I'm fine with it going either way just
thought that we didn't need the additional noise of a wrapper class in this
instance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 338860)
Time Spent: 1h 40m (was: 1.5h)
> Add useful timestamp to job servicer GetJobs
> --------------------------------------------
>
> Key: BEAM-8523
> URL: https://issues.apache.org/jira/browse/BEAM-8523
> Project: Beam
> Issue Type: New Feature
> Components: beam-model
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> As a user querying jobs with JobService.GetJobs, it would be useful if the
> JobInfo result contained timestamps indicating various state changes that may
> have been missed by a client. Useful timestamps include:
>
> * submitted (prepared to the job service)
> * started (executor enters the RUNNING state)
> * completed (executor enters a terminal state)
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
