[
https://issues.apache.org/jira/browse/BEAM-8533?focusedWorklogId=339135&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-339135
]
ASF GitHub Bot logged work on BEAM-8533:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Nov/19 03:48
Start Date: 06/Nov/19 03:48
Worklog Time Spent: 10m
Work Description: sunjincheng121 commented on issue #9956: [BEAM-8533]
Revert "[BEAM-8442] Remove duplicate code for bundle register in Pyth…
URL: https://github.com/apache/beam/pull/9956#issuecomment-550130482
@mxm @ibzib Thanks a lot for your analysis. Really sorry that my commit
breaks the post commit tests. I have investigated this issue and submitted a
new PR #10004 which addressed this issue. It includes the following changes:
- Update the client side implementation of Fn API to make sure registration
is executed successfully before executing process_bundle. Personally I think
that the client side implementation of Fn API should not assume that the
implementation of registration in SDK harness is synchronous. The registration
API itself is asynchronous and the client side implementation should check if
the registration succeed. This will decouple the implementation dependency
between the runner and the SDK harness.
- Remove duplicate registration logic in the Python SDK harness. As you
know, it changed the registration implementation of Python SDK harness to
asynchronous.
Looking forward to your feedback. :)
Best,
Jincheng
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 339135)
Time Spent: 40m (was: 0.5h)
> test_java_expansion_portable_runner failing
> -------------------------------------------
>
> Key: BEAM-8533
> URL: https://issues.apache.org/jira/browse/BEAM-8533
> Project: Beam
> Issue Type: Sub-task
> Components: test-failures
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> probable cause:
> https://github.com/apache/beam/pull/9842#issuecomment-548496295
> 11:13:37 java.util.concurrent.ExecutionException: java.lang.RuntimeException:
> Error received from SDK harness for instruction 72: Traceback (most recent
> call last):11:13:37 File
> "/usr/local/lib/python2.7/site-packages/apache_beam/runners/worker/sdk_worker.py",
> line 173, in _execute*11:13:37* response = task()11:13:37 File
> "/usr/local/lib/python2.7/site-packages/apache_beam/runners/worker/sdk_worker.py",
> line 196, in <lambda>11:13:37 self._execute(lambda:
> worker.do_instruction(work), work)11:13:37 File
> "/usr/local/lib/python2.7/site-packages/apache_beam/runners/worker/sdk_worker.py",
> line 358, in do_instruction*11:13:37* request.instruction_id)11:13:37 File
> "/usr/local/lib/python2.7/site-packages/apache_beam/runners/worker/sdk_worker.py",
> line 378, in process_bundle*11:13:37* instruction_id,
> request.process_bundle_descriptor_id)11:13:37 File
> "/usr/local/lib/python2.7/site-packages/apache_beam/runners/worker/sdk_worker.py",
> line 311, in get*11:13:37* self.fns[bundle_descriptor_id],11:13:37 KeyError:
> u'1-37'
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
