[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=339536&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-339536
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Nov/19 18:37
Start Date: 06/Nov/19 18:37
Worklog Time Spent: 10m
Work Description: udim commented on pull request #9056: [BEAM-7746] Add
python type hints
URL: https://github.com/apache/beam/pull/9056#discussion_r343260172
##########
File path: sdks/python/tox.ini
##########
@@ -160,16 +160,17 @@ commands =
[testenv:py27-lint]
# Checks for py2 syntax errors
deps =
+ -r build-requirements.txt
Review comment:
I agree that the gradle config is not the most efficient. The base
requirements for running Python tests on gradle are pip, virtualenv, and 4
versions of the python interpreter. Tox is installed by setupVirtualenv.
:sdks:python:sdist is run only once (IIUC) for all toxTasks, since running more
than one sdist concurrently is racey and makes our tests flakey.
CC: @markflyhigh who set this up.
Thinking about this now, I have a hunch that the tarball in use doesn't ever
include Cythonized sources (since they are created by sdist when the cython
package is preset).
Source files are copied due to isolation requirements. The Cythonization
process adds files which are automatically picked up if present. Perhaps a
better way to do this is to exclude C files from sdist for the non-cython envs,
but this is the way we do it currently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 339536)
Time Spent: 20h 10m (was: 20h)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 20h 10m
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
