[
https://issues.apache.org/jira/browse/BEAM-8566?focusedWorklogId=339857&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-339857
]
ASF GitHub Bot logged work on BEAM-8566:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Nov/19 10:33
Start Date: 07/Nov/19 10:33
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #10008: [BEAM-8566] Do
not swallow execution errors during checkpointing
URL: https://github.com/apache/beam/pull/10008#discussion_r343579474
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -763,12 +763,19 @@ public final void snapshotState(StateSnapshotContext
context) throws Exception {
// We can't output here anymore because the checkpoint barrier has already
been
// sent downstream. This is going to change with 1.6/1.7's
prepareSnapshotBarrier.
- outputManager.openBuffer();
- // Ensure that no new bundle gets started as part of finishing a bundle
- while (bundleStarted.get()) {
- invokeFinishBundle();
+ try {
+ outputManager.openBuffer();
+ // Ensure that no new bundle gets started as part of finishing a bundle
+ while (bundleStarted.get()) {
+ invokeFinishBundle();
+ }
+ outputManager.closeBuffer();
+ } catch (Exception e) {
Review comment:
https://jira.apache.org/jira/browse/FLINK-14653
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 339857)
Time Spent: 1h 10m (was: 1h)
> Checkpoint buffer is flushed prematurely when another bundle is started
> during checkpointing
> --------------------------------------------------------------------------------------------
>
> Key: BEAM-8566
> URL: https://issues.apache.org/jira/browse/BEAM-8566
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> As part of a checkpoint, the current bundle is finalized. When the bundle is
> finalized, the watermark, currently held back, may also be progressed which
> can cause the start of another bundle. When a new bundle is started, any
> to-be-buffered items from the previous bundle for the pending checkpoint may
> be emitted. This should not happen.
> This only effects portable pipelines where we have to hold back the watermark
> due to the asynchronous processing of elements.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
