[ 
https://issues.apache.org/jira/browse/BEAM-8573?focusedWorklogId=340065&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-340065
 ]

ASF GitHub Bot logged work on BEAM-8573:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Nov/19 18:21
            Start Date: 07/Nov/19 18:21
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on pull request #10016: [BEAM-8573] 
Updates documented signature for @SplitRestriction 
URL: https://github.com/apache/beam/pull/10016
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

            Worklog Id:     (was: 340065)
    Remaining Estimate: 47h 40m  (was: 47h 50m)
            Time Spent: 20m  (was: 10m)

> @SplitRestriction's documented signature is incorrect
> -----------------------------------------------------
>
>                 Key: BEAM-8573
>                 URL: https://issues.apache.org/jira/browse/BEAM-8573
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>    Affects Versions: 2.15.0
>            Reporter: Jonathan Alvarez-Gutierrez
>            Assignee: Jonathan Alvarez-Gutierrez
>            Priority: Minor
>   Original Estimate: 48h
>          Time Spent: 20m
>  Remaining Estimate: 47h 40m
>
> The documented signature for DoFn.SplitRestriction isĀ 
> {code:java}
> List<RestrictionT> splitRestriction( InputT element, RestrictionT 
> restriction);{code}
> This fails to compile with, for example:
> {{@SplitRestriction split(long, OffsetRange): Must return void}}
> It looks like the correct signature is:
> {code:java}
> void splitRestriction(InputT element, RestrictionT restriction,
>     OutputReceiver<RestrictionT> restriction);{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to