[
https://issues.apache.org/jira/browse/BEAM-8512?focusedWorklogId=340139&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-340139
]
ASF GitHub Bot logged work on BEAM-8512:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Nov/19 20:29
Start Date: 07/Nov/19 20:29
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #9998: [BEAM-8512] Add
integration tests for flink_runner.py
URL: https://github.com/apache/beam/pull/9998#discussion_r343858825
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1953,8 +1953,10 @@ class BeamModulePlugin implements Plugin<Project> {
}
project.ext.addPortableWordCountTasks = {
->
- addPortableWordCountTask(false)
- addPortableWordCountTask(true)
+ addPortableWordCountTask(false, "PortableRunner")
Review comment:
> Theoretically, the PortableRunner is a subset of FlinkRunner, but there
are still things that can go wrong
+1 As long as PortableRunner remains a publicly documented option (and it
will probably have to for at least a little while longer) we should test it.
Also, they are testing slightly different things -- PortableRunner starts a
containerized job server, while FlinkRunner (when local) starts the job server
in a Java subprocess.
> Since these tasks are Flink specific, should they be renamed and possibly
moved out of BeamModulePlugin?
I'm going to add these tasks to Spark (eventually).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 340139)
Time Spent: 1h 20m (was: 1h 10m)
> Add integration tests for Python "flink_runner.py"
> --------------------------------------------------
>
> Key: BEAM-8512
> URL: https://issues.apache.org/jira/browse/BEAM-8512
> Project: Beam
> Issue Type: Test
> Components: runner-flink, sdk-py-core
> Reporter: Maximilian Michels
> Assignee: Kyle Weaver
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> There are currently no integration tests for the Python FlinkRunner. We need
> a set of tests similar to {{flink_runner_test.py}} which currently use the
> PortableRunner and not the FlinkRunner.
> CC [~robertwb] [~ibzib] [~thw]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
