[
https://issues.apache.org/jira/browse/BEAM-5878?focusedWorklogId=340640&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-340640
]
ASF GitHub Bot logged work on BEAM-5878:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Nov/19 18:04
Start Date: 08/Nov/19 18:04
Worklog Time Spent: 10m
Work Description: tvalentyn commented on issue #9686: [BEAM-5878] update
dill min version to 0.3.1.1 and add test for functions with Keyword-only
arguments
URL: https://github.com/apache/beam/pull/9686#issuecomment-551930923
Merging since the tests passed on 0834b416ab45cc3afbac35f5b9d3c5d6104528bb,
and second commit does not affect any tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 340640)
Time Spent: 16h 20m (was: 16h 10m)
> Support DoFns with Keyword-only arguments in Python 3.
> ------------------------------------------------------
>
> Key: BEAM-5878
> URL: https://issues.apache.org/jira/browse/BEAM-5878
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: yoshiki obata
> Priority: Minor
> Time Spent: 16h 20m
> Remaining Estimate: 0h
>
> Python 3.0 [adds a possibility|https://www.python.org/dev/peps/pep-3102/] to
> define functions with keyword-only arguments.
> Currently Beam does not handle them correctly. [~ruoyu] pointed out [one
> place|https://github.com/apache/beam/blob/a56ce43109c97c739fa08adca45528c41e3c925c/sdks/python/apache_beam/typehints/decorators.py#L118]
> in our codebase that we should fix: in Python in 3.0 inspect.getargspec()
> will fail on functions with keyword-only arguments, but a new method
> [inspect.getfullargspec()|https://docs.python.org/3/library/inspect.html#inspect.getfullargspec]
> supports them.
> There may be implications for our (best-effort) type-hints machinery.
> We should also add a Py3-only unit tests that covers DoFn's with keyword-only
> arguments once Beam Python 3 tests are in a good shape.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
