[ 
https://issues.apache.org/jira/browse/BEAM-8587?focusedWorklogId=340763&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-340763
 ]

ASF GitHub Bot logged work on BEAM-8587:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Nov/19 21:57
            Start Date: 08/Nov/19 21:57
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on pull request #10041: [BEAM-8587] 
TestStream for Dataflow runner
URL: https://github.com/apache/beam/pull/10041#discussion_r344380010
 
 

 ##########
 File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
 ##########
 @@ -1195,6 +1196,49 @@ def run__NativeWrite(self, transform_node, options):
          PropertyNames.STEP_NAME: input_step.proto.name,
          PropertyNames.OUTPUT_NAME: input_step.get_output(input_tag)})
 
+  @unittest.skip("This is not a test, despite the name.")
 
 Review comment:
   ```suggestion
     @unittest.skip("The test setup currently matches this method and attempts 
to run it as a test which is why we explicitly mark this with skip.")
   ```
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 340763)
    Time Spent: 20m  (was: 10m)

> Add TestStream support for Dataflow runner
> ------------------------------------------
>
>                 Key: BEAM-8587
>                 URL: https://issues.apache.org/jira/browse/BEAM-8587
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-dataflow, testing
>            Reporter: Andrew Crites
>            Assignee: Andrew Crites
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> TestStream support needed to test features like late data and processing time 
> triggers on local Dataflow runner.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to