ASF GitHub Bot logged work on BEAM-8427:

                Author: ASF GitHub Bot
            Created on: 08/Nov/19 22:04
            Start Date: 08/Nov/19 22:04
    Worklog Time Spent: 10m 
      Work Description: TheNeuralBit commented on pull request #9892: 
[BEAM-8427] [SQL] buildIOWrite for MongoDb Table
URL: https://github.com/apache/beam/pull/9892#discussion_r344384368

 File path: sdks/java/core/src/main/java/org/apache/beam/sdk/util/RowJson.java
 @@ -351,6 +351,9 @@ private void writeValue(JsonGenerator gen, FieldType type, 
Object value) throws
         case ROW:
           writeRow((Row) value, type.getRowSchema(), gen);
+        case LOGICAL_TYPE:
+          writeValue(gen, type.getLogicalType().getBaseType(), value);
+          break;
 Review comment:
   Nice! For some reason I was thinking this would be a big pain, but this is 
nice and simple :+1: 
   Could you add some tests of logical types to `RowJsonTest`? You could just 
use `LogicalTypes.FixedSizeBytes` I think.
   Probably the easiest way is to add a `makeLogicalTypeTestCase` here: 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 340769)
    Time Spent: 6h 10m  (was: 6h)

> [SQL] Add support for MongoDB source
> ------------------------------------
>                 Key: BEAM-8427
>                 URL: https://issues.apache.org/jira/browse/BEAM-8427
>             Project: Beam
>          Issue Type: New Feature
>          Components: dsl-sql
>            Reporter: Kirill Kozlov
>            Assignee: Kirill Kozlov
>            Priority: Major
>          Time Spent: 6h 10m
>  Remaining Estimate: 0h
> In progress:
>  * Create a MongoDB table and table provider.
>  * Implement buildIOReader
>  * Support primitive types
> Still needs to be done:
>  * Implement buildIOWrite
>  * improve getTableStatistics

This message was sent by Atlassian Jira

Reply via email to