[ 
https://issues.apache.org/jira/browse/BEAM-8579?focusedWorklogId=340800&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-340800
 ]

ASF GitHub Bot logged work on BEAM-8579:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Nov/19 23:02
            Start Date: 08/Nov/19 23:02
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on issue #10046: [BEAM-8579] Strip 
UTF-8 BOM from TextSource output.
URL: https://github.com/apache/beam/pull/10046#issuecomment-552024365
 
 
   Overall the PR and tests look good just the location of the tests should 
move.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 340800)
    Time Spent: 50m  (was: 40m)

> Strip UTF-8 BOM bytes (if present) in TextSource.
> -------------------------------------------------
>
>                 Key: BEAM-8579
>                 URL: https://issues.apache.org/jira/browse/BEAM-8579
>             Project: Beam
>          Issue Type: Bug
>          Components: io-java-text
>    Affects Versions: 2.15.0
>            Reporter: Changming Ma
>            Assignee: Changming Ma
>            Priority: Minor
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> TextSource in the org.apache.beam.sdk.io package can handle UTF-8 encoded 
> files, and when the file contains byte order mark (BOM), it will preserve it 
> in the output. According to Unicode standard 
> ([http://www.unicode.org/versions/Unicode5.0.0/ch02.pdf|https://www.google.com/url?q=http://www.unicode.org/versions/Unicode5.0.0/ch02.pdf&sa=D&usg=AFQjCNF_PW0McUUnM1UrvZSIwgvAj1uUKw]):
>  "Use of a BOM is neither required nor recommended for UTF-8". UTF-8 with a 
> BOM will also be a potential problem for some Java implementations (e.g., 
> [https://bugs.java.com/bugdatabase/view_bug.do?bug_id=4508058|https://www.google.com/url?q=https://bugs.java.com/bugdatabase/view_bug.do?bug_id%3D4508058&sa=D&usg=AFQjCNEdT7vUK99N5bxQc9fkCt-uIG2v7Q]).
>  As a general practice, it's suggested to use UTF-8 without BOM.
> Proposal: remove BOM bytes in the output from TextSource.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to