[
https://issues.apache.org/jira/browse/BEAM-8597?focusedWorklogId=341527&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-341527
]
ASF GitHub Bot logged work on BEAM-8597:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Nov/19 22:52
Start Date: 11/Nov/19 22:52
Worklog Time Spent: 10m
Work Description: liumomo315 commented on pull request #10043:
[BEAM-8597] Allow TestStream trigger tests to run on other runners.
URL: https://github.com/apache/beam/pull/10043#discussion_r344946461
##########
File path: sdks/python/apache_beam/testing/test_stream.py
##########
@@ -66,6 +68,28 @@ def __ne__(self, other):
# TODO(BEAM-5949): Needed for Python 2 compatibility.
return not self == other
+ @abstractmethod
+ def to_runner_api(self, element_coder):
+ raise NotImplementedError
+
+ @staticmethod
+ def from_runner_api(proto, element_coder):
Review comment:
For my understanding: Is the reason to group the from_runner_api
implementation into the abstract class (while triggers/windows leave the
from_runner_api to the concrete classes) that we believe TestStream will only
have very limited types of element?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 341527)
Time Spent: 50m (was: 40m)
> Allow TestStream trigger tests to run on other runners.
> -------------------------------------------------------
>
> Key: BEAM-8597
> URL: https://issues.apache.org/jira/browse/BEAM-8597
> Project: Beam
> Issue Type: Improvement
> Components: testing
> Reporter: Robert Bradshaw
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
