[
https://issues.apache.org/jira/browse/BEAM-8557?focusedWorklogId=341542&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-341542
]
ASF GitHub Bot logged work on BEAM-8557:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Nov/19 23:45
Start Date: 11/Nov/19 23:45
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #9991:
[BEAM-8557]Add log for the dropped unknown response
URL: https://github.com/apache/beam/pull/9991#discussion_r344959866
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/FnApiControlClient.java
##########
@@ -158,6 +158,8 @@ public void onNext(BeamFnApi.InstructionResponse response)
{
"Error received from SDK harness for instruction %s: %s",
response.getInstructionId(), response.getError())));
}
+ } else {
+ LOG.warn("Dropped unknown InstructionResponse {}", response);
Review comment:
Tiny style suggestion: move the error case to the top. Reduce one level of
curly braces.
```java
if (responseFuture == null) {
LOG.warn(...)
return;
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 341542)
Time Spent: 2h (was: 1h 50m)
> Clean up useless null check.
> ----------------------------
>
> Key: BEAM-8557
> URL: https://issues.apache.org/jira/browse/BEAM-8557
> Project: Beam
> Issue Type: Sub-task
> Components: runner-core, sdk-java-harness
> Reporter: sunjincheng
> Assignee: sunjincheng
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> I think we do not need null check here:
> [https://github.com/apache/beam/blob/master/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/FnApiControlClient.java#L151]
> Because before the the `onNext` call, the `Future` already put into the queue
> in `handle` method.
>
> I found the test as follows:
> {code:java}
> @Test
> public void testUnknownResponseIgnored() throws Exception{code}
> I do not know why we need test this case? I think it would be better if we
> throw the Exception for an UnknownResponse, otherwise, this may hidden a
> potential bug.
> Please correct me if there anything I misunderstand @kennknowles
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
