[
https://issues.apache.org/jira/browse/BEAM-8613?focusedWorklogId=341544&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-341544
]
ASF GitHub Bot logged work on BEAM-8613:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Nov/19 23:48
Start Date: 11/Nov/19 23:48
Worklog Time Spent: 10m
Work Description: nrusch commented on pull request #10064: [BEAM-8613]
Add environment variable support to Docker environment
URL: https://github.com/apache/beam/pull/10064#discussion_r344960620
##########
File path: sdks/python/apache_beam/transforms/environments.py
##########
@@ -37,6 +37,11 @@
'SubprocessSDKEnvironment', 'RunnerAPIEnvironmentHolder']
+def _looks_like_json(config_string):
+ import re
+ return re.match(r'\s*\{.*\}\s*$', config_string)
Review comment:
Ah, good call. Updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 341544)
Time Spent: 40m (was: 0.5h)
> Add environment variable support to Docker environment
> ------------------------------------------------------
>
> Key: BEAM-8613
> URL: https://issues.apache.org/jira/browse/BEAM-8613
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution, runner-core, runner-direct
> Reporter: Nathan Rusch
> Priority: Trivial
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The Process environment allows specifying environment variables via a map
> field on its payload message. The Docker environment should support this same
> pattern, and forward the contents of the map through to the container runtime.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
