[
https://issues.apache.org/jira/browse/BEAM-8442?focusedWorklogId=341646&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-341646
]
ASF GitHub Bot logged work on BEAM-8442:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Nov/19 03:24
Start Date: 12/Nov/19 03:24
Worklog Time Spent: 10m
Work Description: sunjincheng121 commented on issue #10004: [BEAM-8442]
Unify bundle register in Python SDK harness
URL: https://github.com/apache/beam/pull/10004#issuecomment-552717309
@robertwb
Thanks a lot for comments. After this change, if the registration failed,
the data channel between the runner and the SDK harness will not be established
and so the data transmission from the runner to the SDK harness will be
[timedout](https://github.com/apache/beam/blob/74ea7496ff486640affbf2e6ab4a45d3ea25efc8/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/data/GrpcDataService.java#L170).
At that time, the registration failure could be reported. This is also the
same case for the process bundle instruction before and after this change. Are
you concerning that we should detect the registration failure at the early
time? If it's the case, how do we deal with the process bundle instruction,
should we keep the same behavior for both the registration and process bundle
instruction.
What do you think?
Best, Jincheng
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 341646)
Time Spent: 4h 50m (was: 4h 40m)
> Unify bundle register in Python SDK harness
> -------------------------------------------
>
> Key: BEAM-8442
> URL: https://issues.apache.org/jira/browse/BEAM-8442
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-harness
> Reporter: sunjincheng
> Assignee: sunjincheng
> Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> There are two methods for bundle register in Python SDK harness:
> `SdkHarness._request_register` and `SdkWorker.register.` It should be unfied.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
