[ 
https://issues.apache.org/jira/browse/BEAM-8603?focusedWorklogId=342042&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-342042
 ]

ASF GitHub Bot logged work on BEAM-8603:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Nov/19 17:02
            Start Date: 12/Nov/19 17:02
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on pull request #10055: [BEAM-8603] 
Add Python SqlTransform example script
URL: https://github.com/apache/beam/pull/10055#discussion_r345328998
 
 

 ##########
 File path: sdks/java/extensions/sql/build.gradle
 ##########
 @@ -24,6 +24,7 @@ plugins {
 }
 applyJavaNature(
   automaticModuleName: 'org.apache.beam.sdk.extensions.sql',
+  shadowClosure: {},
 
 Review comment:
   I don't think we want to do this since normal SQL users don't want to be 
using an artifact meant for the expansion service. It seems as though we should 
have the expansion service gradle project build one uber artifact containing 
all the xlang transforms we want to vend.
   
   We could have multiple shadowJar tasks and produce multiple artifacts along 
this line but this seems overly complex initially.
   
   @chamikaramj Is there an initial strategy we are following for how we want 
to build xlang expansion service jars?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 342042)
    Time Spent: 40m  (was: 0.5h)

> Add Python SqlTransform example script
> --------------------------------------
>
>                 Key: BEAM-8603
>                 URL: https://issues.apache.org/jira/browse/BEAM-8603
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py-core
>            Reporter: Brian Hulette
>            Assignee: Brian Hulette
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to