[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=342322&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-342322
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Nov/19 00:52
Start Date: 13/Nov/19 00:52
Worklog Time Spent: 10m
Work Description: chadrik commented on pull request #9915: [BEAM-7746]
Add python type hints (part 1)
URL: https://github.com/apache/beam/pull/9915#discussion_r345522056
##########
File path: sdks/python/apache_beam/runners/direct/transform_evaluator.py
##########
@@ -65,16 +71,23 @@
from apache_beam.utils.timestamp import MIN_TIMESTAMP
from apache_beam.utils.timestamp import Timestamp
+if TYPE_CHECKING:
+ from apache_beam.io.gcp.pubsub import _PubSubSource
Review comment:
I forgot to mention, it is not an error for those types to be missing,
unless you enable it (which I did not do). If stubs or typed source for that
class are not available it effectively becomes `Any`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 342322)
Time Spent: 22.5h (was: 22h 20m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 22.5h
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
