[
https://issues.apache.org/jira/browse/BEAM-8338?focusedWorklogId=342632&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-342632
]
ASF GitHub Bot logged work on BEAM-8338:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Nov/19 14:30
Start Date: 13/Nov/19 14:30
Worklog Time Spent: 10m
Work Description: echauchot commented on issue #10025: [BEAM-8338]
Support ES 7.x for ElasticsearchIO
URL: https://github.com/apache/beam/pull/10025#issuecomment-553428536
I'm not a big fan of ifs either but the aim was to have a single production
code (for maintenance) in a single module (for users) . And as there were only
some located differences (mainly split), a simple if could do.
Also please note 2 things: discrete versions are used instead of > x in the
code to avoid running on non-tested versions. Also we used a very low level ES
client (rest client) which is (was?) the only one compatible with all the
versions of ES, specially to have a single production code base of ESIO.
If you want, you can submit a refactor PR to improve it. I'll be happy of
it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 342632)
Time Spent: 3h 10m (was: 3h)
> Support ES 7.x for ElasticsearchIO
> ----------------------------------
>
> Key: BEAM-8338
> URL: https://issues.apache.org/jira/browse/BEAM-8338
> Project: Beam
> Issue Type: Improvement
> Components: io-java-elasticsearch
> Reporter: Michal Brunát
> Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Elasticsearch has released 7.4 but ElasticsearchIO only supports 2x,5.x,6.x.
> We should support ES 7.x for ElasticsearchIO.
> [https://www.elastic.co/guide/en/elasticsearch/reference/current/index.html]
>
> [https://github.com/apache/beam/blob/master/sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
