[
https://issues.apache.org/jira/browse/BEAM-8379?focusedWorklogId=343657&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-343657
]
ASF GitHub Bot logged work on BEAM-8379:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Nov/19 18:58
Start Date: 14/Nov/19 18:58
Worklog Time Spent: 10m
Work Description: KevinGG commented on pull request #10062: [BEAM-8379]
Cache Eviction
URL: https://github.com/apache/beam/pull/10062#discussion_r346489788
##########
File path:
sdks/python/apache_beam/runners/interactive/interactive_environment.py
##########
@@ -74,10 +83,10 @@ def __init__(self, cache_manager=None):
self._pipeline_results = {}
# Always watch __main__ module.
self.watch('__main__')
- # Do a warning level logging if current python version is below 3.5.3.
- if sys.version_info < (3, 5, 3):
+ # Do a warning level logging if current python version is below 3.6.
+ if sys.version_info < (3, 6):
self._is_py_version_ready = False
- logging.warning('Interactive Beam requires Python 3.5.3+.')
+ logging.warning('Interactive Beam requires Python 3.6+.')
Review comment:
The assertions in unittest module for if something is called such as
`assert_called` are not available in some older Python versions.
To make it even worse, some features introduced in Python3 has been patched
back to some Python2 versions but not some older Python3 versions. So it's
possible to see tests passing in Py3.6+ and Py2.7+ but fail for Py3.5.
The 3.5.3 is only a prerequisite for dependency `jsons` (not `json`) that
allows us to serialize any Python object into json format without providing
schema of the data. That's how we can build dataframe from arbitrary data
implicitly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 343657)
Time Spent: 1.5h (was: 1h 20m)
> Cache Eviction for Interactive Beam
> -----------------------------------
>
> Key: BEAM-8379
> URL: https://issues.apache.org/jira/browse/BEAM-8379
> Project: Beam
> Issue Type: New Feature
> Components: runner-py-interactive
> Reporter: Ning Kang
> Assignee: Ning Kang
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Evicts cache created by Interactive Beam when an IPython kernel is restarted
> or terminated to release the resource usage that is no longer needed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
