[
https://issues.apache.org/jira/browse/BEAM-8666?focusedWorklogId=343755&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-343755
]
ASF GitHub Bot logged work on BEAM-8666:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Nov/19 21:25
Start Date: 14/Nov/19 21:25
Worklog Time Spent: 10m
Work Description: chamikaramj commented on issue #10112: [BEAM-8666]
Remove dependency between DataflowRunner and PortableRunner introduced by
PR#9811
URL: https://github.com/apache/beam/pull/10112#issuecomment-554086862
LGTM. Thanks for the fix.
Will merge after tests pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 343755)
Time Spent: 40m (was: 0.5h)
> Remove dependency between DataflowRunner and PortableRunner introduced by
> PR#9811
> ---------------------------------------------------------------------------------
>
> Key: BEAM-8666
> URL: https://issues.apache.org/jira/browse/BEAM-8666
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Wanqi Lyu
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> PR#9811 creates a new dependency between `DataflowRunner` and
> `PortableRunner`. `DataflowRunner` uses `DockerEnvironment` but there was no
> need for `DataflowRunner` to depend on the `PortableRunner` module before. We
> will refactor out `default_docker_image()` method to live in
> `apache_beam.transforms.Environment`.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
