[
https://issues.apache.org/jira/browse/BEAM-8670?focusedWorklogId=344174&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-344174
]
ASF GitHub Bot logged work on BEAM-8670:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Nov/19 11:41
Start Date: 15/Nov/19 11:41
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #10124: [BEAM-8670]
Manage environment parallelism in DefaultJobBundleFactory
URL: https://github.com/apache/beam/pull/10124#discussion_r346781521
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/DefaultJobBundleFactory.java
##########
@@ -161,26 +181,33 @@ private static int
getEnvironmentExpirationMillis(JobInfo jobInfo) {
if (environmentExpirationMillis > 0) {
builder = builder.expireAfterWrite(environmentExpirationMillis,
TimeUnit.MILLISECONDS);
}
- return builder.build(
- new CacheLoader<Environment, WrappedSdkHarnessClient>() {
- @Override
- public WrappedSdkHarnessClient load(Environment environment) throws
Exception {
- EnvironmentFactory.Provider environmentFactoryProvider =
- environmentFactoryProviderMap.get(environment.getUrn());
- ServerFactory serverFactory =
environmentFactoryProvider.getServerFactory();
- ServerInfo serverInfo = serverInfoCreator.apply(serverFactory);
- EnvironmentFactory environmentFactory =
- environmentFactoryProvider.createEnvironmentFactory(
- serverInfo.getControlServer(),
- serverInfo.getLoggingServer(),
- serverInfo.getRetrievalServer(),
- serverInfo.getProvisioningServer(),
- clientPool,
- stageIdGenerator);
- return WrappedSdkHarnessClient.wrapping(
- environmentFactory.createEnvironment(environment), serverInfo);
- }
- });
+
+ ImmutableList.Builder caches = ImmutableList.builder();
Review comment:
```suggestion
ImmutableList.Builder<LoadingCache<Environment,
WrappedSdkHarnessClient>> caches = ImmutableList.<>builder();
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 344174)
Time Spent: 40m (was: 0.5h)
> Manage environment parallelism in DefaultJobBundleFactory
> ---------------------------------------------------------
>
> Key: BEAM-8670
> URL: https://issues.apache.org/jira/browse/BEAM-8670
> Project: Beam
> Issue Type: Task
> Components: runner-core
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: Major
> Labels: portability
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Multiple (remote) environments are currently managed through logic in
> ExecutableStageContext. This pins ExecutableStage to a given environment for
> the lifetime of a job and makes it impossible to implement an alternative
> scheduling strategy.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
