[
https://issues.apache.org/jira/browse/BEAM-7473?focusedWorklogId=345613&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-345613
]
ASF GitHub Bot logged work on BEAM-7473:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Nov/19 22:17
Start Date: 18/Nov/19 22:17
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #10118: [BEAM-7473]
Pack RangeTracker into restriction
URL: https://github.com/apache/beam/pull/10118#discussion_r347637047
##########
File path: sdks/python/apache_beam/io/iobase.py
##########
@@ -1456,10 +1473,17 @@ def try_split(self, fraction_of_remainder):
residual_weight = self._weight - primary_weight
# Update self._weight to primary weight
self._weight = primary_weight
- return (SourceBundle(primary_weight, self._source, start_pos,
- split_pos),
- SourceBundle(residual_weight, self._source, split_pos,
- stop_pos))
+ return (
Review comment:
You could add a split method to the _SDFBoundedSourceRestriction that would
contain most of the logic of this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 345613)
Time Spent: 1h 10m (was: 1h)
> Update RestrictionTracker within Python to not be required to be thread safe
> ----------------------------------------------------------------------------
>
> Key: BEAM-7473
> URL: https://issues.apache.org/jira/browse/BEAM-7473
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core, sdk-py-harness
> Reporter: Luke Cwik
> Assignee: Boyuan Zhang
> Priority: Major
> Fix For: 2.17.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The commit
> [https://github.com/apache/beam/commit/8faffb2bcf28ccab5e9a95322743cc60df65077c#diff-ed95abb6bc30a9ed07faef5c3fea93f0]
> modified the Java SDK removed the need for users to be thread safe and
> instead made the framework provide the necessary locking around a restriction
> tracker.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
