[
https://issues.apache.org/jira/browse/BEAM-8575?focusedWorklogId=345621&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-345621
]
ASF GitHub Bot logged work on BEAM-8575:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Nov/19 22:22
Start Date: 18/Nov/19 22:22
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #10102: [BEAM-8575]
Test flatten a single PC and test flatten a flattened PC
URL: https://github.com/apache/beam/pull/10102#discussion_r347640740
##########
File path: sdks/python/apache_beam/transforms/ptransform_test.py
##########
@@ -550,11 +563,23 @@ def test_flatten_pcollections_in_iterable(self):
assert_that(result, equal_to([0, 1, 2, 3, 4, 5, 6, 7]))
pipeline.run()
+ @attr('ValidatesRunner')
+ def test_flatten_a_flattened_pcollection(self):
+ pipeline = TestPipeline()
+ pcoll_1 = pipeline | 'Start 1' >> beam.Create([0, 1, 2, 3])
+ pcoll_2 = pipeline | 'Start 2' >> beam.Create([4, 5, 6, 7])
+ result = ((pcoll_1, pcoll_2) | 'Flatten' >> beam.Flatten(),
+ ) |'Flatten again' >> beam.Flatten()
+ assert_that(result, equal_to([x for x in range(8)]))
+ pipeline.run()
+
+ @attr('ValidatesRunner')
Review comment:
This raises an error on construction, should not be ValidatesRunner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 345621)
Time Spent: 8h 20m (was: 8h 10m)
> Add more Python validates runner tests
> --------------------------------------
>
> Key: BEAM-8575
> URL: https://issues.apache.org/jira/browse/BEAM-8575
> Project: Beam
> Issue Type: Test
> Components: sdk-py-core, testing
> Reporter: wendy liu
> Assignee: wendy liu
> Priority: Major
> Time Spent: 8h 20m
> Remaining Estimate: 0h
>
> This is the umbrella issue to track the work of adding more Python tests to
> improve test coverage.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
