[
https://issues.apache.org/jira/browse/BEAM-8016?focusedWorklogId=345705&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-345705
]
ASF GitHub Bot logged work on BEAM-8016:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Nov/19 00:22
Start Date: 19/Nov/19 00:22
Worklog Time Spent: 10m
Work Description: qinyeli commented on pull request #10132: [BEAM-8016]
Pipeline Graph
URL: https://github.com/apache/beam/pull/10132#discussion_r347676584
##########
File path: sdks/python/apache_beam/runners/interactive/pipeline_instrument.py
##########
@@ -80,7 +80,10 @@ def __init__(self, pipeline, options=None):
# A mapping from PCollection id to python id() value in user defined
# pipeline instance.
(self._pcoll_version_map,
- self._cacheables) = cacheables(self.pcolls_to_pcoll_id)
+ self._cacheables,
Review comment:
Adding comment here since GitHub does not allow comments on unchanged lines.
It's probably not obvious what it means to "instrument" a pipeline. From my
context back when working on Interactive Beam, I would guess it's something
similar to the original pipeline_analyzer, (and I have to admit that "analyze"
pipeline was not a much better.), but it's still fuzzy.
Maybe adding some comment summarizing what pipeline_instrument does would be
good. In a separate PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 345705)
Time Spent: 1h 50m (was: 1h 40m)
> Render Beam Pipeline as DOT with Interactive Beam
> ---------------------------------------------------
>
> Key: BEAM-8016
> URL: https://issues.apache.org/jira/browse/BEAM-8016
> Project: Beam
> Issue Type: Improvement
> Components: runner-py-interactive
> Reporter: Ning Kang
> Assignee: Ning Kang
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> With work in https://issues.apache.org/jira/browse/BEAM-7760, Beam pipeline
> converted to DOT then rendered should mark user defined variables on edges.
> With work in https://issues.apache.org/jira/browse/BEAM-7926, it might be
> redundant or confusing to render arbitrary random sample PCollection data on
> edges.
> We'll also make sure edges in the graph corresponds to output -> input
> relationship in the user defined pipeline. Each edge is one output. If
> multiple down stream inputs take the same output, it should be rendered as
> one edge diverging into two instead of two edges.
> For advanced interactivity highlight where each execution highlights the part
> of the pipeline really executed from the original pipeline, we'll also
> provide the support in beta.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
