[
https://issues.apache.org/jira/browse/BEAM-8629?focusedWorklogId=345769&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-345769
]
ASF GitHub Bot logged work on BEAM-8629:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Nov/19 02:29
Start Date: 19/Nov/19 02:29
Worklog Time Spent: 10m
Work Description: udim commented on pull request #10080: [BEAM-8629]
Don't return mutable class type hints.
URL: https://github.com/apache/beam/pull/10080#discussion_r347705356
##########
File path: sdks/python/apache_beam/typehints/decorators.py
##########
@@ -340,6 +340,22 @@ def __repr__(self):
return 'IOTypeHints[inputs=%s, outputs=%s]' % (
self.input_types, self.output_types)
+ def __eq__(self, other):
Review comment:
Why were these 3 methods needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 345769)
Time Spent: 0.5h (was: 20m)
> WithTypeHints._get_or_create_type_hints may return a mutable copy of the
> class type hints.
> ------------------------------------------------------------------------------------------
>
> Key: BEAM-8629
> URL: https://issues.apache.org/jira/browse/BEAM-8629
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
