[
https://issues.apache.org/jira/browse/BEAM-7274?focusedWorklogId=345813&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-345813
]
ASF GitHub Bot logged work on BEAM-7274:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Nov/19 06:02
Start Date: 19/Nov/19 06:02
Worklog Time Spent: 10m
Work Description: reuvenlax commented on pull request #8690: [BEAM-7274]
Implement the Protobuf schema provider
URL: https://github.com/apache/beam/pull/8690#discussion_r347743622
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/values/Row.java
##########
@@ -554,6 +555,12 @@ public Builder withFieldValueGetters(
return this;
}
+ /** The FieldValueGetters will handle the conversion for Arrays, Maps and
Rows. */
+ public Builder withFieldValueGettersHandleCollections(boolean
collectionHandledByGetter) {
+ this.collectionHandledByGetter = collectionHandledByGetter;
+ return this;
+ }
Review comment:
Can you help me understand this a bit more? Why does it not work to cache
lists for protocol buffers? We saw repeated array conversion to be a big
problem (which is why we cache them). I'm wondering if we could instead cache a
lazy array like we do with iterables.
I'll take a closer look at this code to figure it out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 345813)
Time Spent: 9.5h (was: 9h 20m)
> Protobuf Beam Schema support
> ----------------------------
>
> Key: BEAM-7274
> URL: https://issues.apache.org/jira/browse/BEAM-7274
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Alex Van Boxel
> Assignee: Alex Van Boxel
> Priority: Minor
> Time Spent: 9.5h
> Remaining Estimate: 0h
>
> Add support for the new Beam Schema to the Protobuf extension.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
