[
https://issues.apache.org/jira/browse/BEAM-8729?focusedWorklogId=346111&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-346111
]
ASF GitHub Bot logged work on BEAM-8729:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Nov/19 17:14
Start Date: 19/Nov/19 17:14
Worklog Time Spent: 10m
Work Description: suztomo commented on pull request #10154: [BEAM-8729]
Gracefully skip irrelevant http/https lines from gradle-version-plugin
URL: https://github.com/apache/beam/pull/10154#discussion_r348057119
##########
File path:
.test-infra/jenkins/dependency_check/dependency_check_report_generator.py
##########
@@ -103,6 +103,9 @@ def prioritize_dependencies(deps, sdk_type):
for dep in deps:
try:
+ if re.match(r'https?://', dep.lstrip()):
+ # Gralde-version-plugin's output contains URLs of the libraries
Review comment:
Thanks! Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 346111)
Time Spent: 40m (was: 0.5h)
> beam_Dependency_Check to skip HTTP gracefully
> ---------------------------------------------
>
> Key: BEAM-8729
> URL: https://issues.apache.org/jira/browse/BEAM-8729
> Project: Beam
> Issue Type: Improvement
> Components: build-system
> Reporter: Tomo Suzuki
> Assignee: Tomo Suzuki
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I think it should skip http URL silently rather than throwing an error.
> https://builds.apache.org/job/beam_Dependency_Check/235/console
> {noformat}
> 14:44:14 INFO:root:
> 14:44:14
> 14:44:14 Start processing: https://hbase.apache.org
> 14:44:14
> 14:44:14 Traceback (most recent call last):
> 14:44:14 File
> "/home/jenkins/jenkins-slave/workspace/beam_Dependency_Check/src/.test-infra/jenkins/dependency_check/dependency_check_report_generator.py",
> line 107, in prioritize_dependencies
> 14:44:14 dep_name, curr_ver, latest_ver = extract_single_dep(dep)
> 14:44:14 File
> "/home/jenkins/jenkins-slave/workspace/beam_Dependency_Check/src/.test-infra/jenkins/dependency_check/dependency_check_report_generator.py",
> line 76, in extract_single_dep
> 14:44:14 raise InvalidFormatError("Failed to extract the dependency
> information: {}".format(dep))
> 14:44:14 InvalidFormatError: Failed to extract the dependency information:
> https://hbase.apache.org
> 14:44:14
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
