[
https://issues.apache.org/jira/browse/BEAM-8575?focusedWorklogId=347123&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-347123
]
ASF GitHub Bot logged work on BEAM-8575:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Nov/19 01:59
Start Date: 21/Nov/19 01:59
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #10173: [BEAM-8575]
Added two unit tests in CombineTest class to test AccumulatingCombine
URL: https://github.com/apache/beam/pull/10173#discussion_r348864276
##########
File path: sdks/python/apache_beam/transforms/combiners_test.py
##########
@@ -393,6 +395,54 @@ def test_global_fanout(self):
| beam.CombineGlobally(combine.MeanCombineFn()).with_fanout(11))
assert_that(result, equal_to([49.5]))
+ @attr('ValidatesRunner')
+ def test_accumulating_combine(self):
Review comment:
This seems mostly redundant with
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/portability/fn_api_runner_test.py#L562
, other than the fact that it does globally as well. (Globally is just built
on top of per-key, so there's little value in making it validates runner.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 347123)
Time Spent: 15h 20m (was: 15h 10m)
> Add more Python validates runner tests
> --------------------------------------
>
> Key: BEAM-8575
> URL: https://issues.apache.org/jira/browse/BEAM-8575
> Project: Beam
> Issue Type: Test
> Components: sdk-py-core, testing
> Reporter: wendy liu
> Assignee: wendy liu
> Priority: Major
> Time Spent: 15h 20m
> Remaining Estimate: 0h
>
> This is the umbrella issue to track the work of adding more Python tests to
> improve test coverage.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
