[
https://issues.apache.org/jira/browse/BEAM-8740?focusedWorklogId=347527&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-347527
]
ASF GitHub Bot logged work on BEAM-8740:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Nov/19 17:07
Start Date: 21/Nov/19 17:07
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #10153:
[BEAM-8740] TestPubsub ignores timeout
URL: https://github.com/apache/beam/pull/10153#discussion_r348495610
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/TestPubsub.java
##########
@@ -202,9 +202,11 @@ public void publish(List<PubsubMessage> messages) throws
IOException {
public List<PubsubMessage> pull(int maxBatchSize) throws IOException {
List<PubsubClient.IncomingMessage> messages =
pubsub.pull(0, subscriptionPath, maxBatchSize, true);
- pubsub.acknowledge(
- subscriptionPath,
- messages.stream().map(msg ->
msg.ackId).collect(ImmutableList.toImmutableList()));
+ if (!messages.isEmpty()) {
Review comment:
yeah, the acknowledge call throws if you give it an empty list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 347527)
Time Spent: 0.5h (was: 20m)
> TestPubsub ignores timeout
> --------------------------
>
> Key: BEAM-8740
> URL: https://issues.apache.org/jira/browse/BEAM-8740
> Project: Beam
> Issue Type: Bug
> Components: testing
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
