[ 
https://issues.apache.org/jira/browse/BEAM-7390?focusedWorklogId=347897&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-347897
 ]

ASF GitHub Bot logged work on BEAM-7390:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Nov/19 03:17
            Start Date: 22/Nov/19 03:17
    Worklog Time Spent: 10m 
      Work Description: davidcavazos commented on pull request #10175: 
[BEAM-7390] Add code snippet for Max
URL: https://github.com/apache/beam/pull/10175#discussion_r349418508
 
 

 ##########
 File path: 
sdks/python/apache_beam/examples/snippets/transforms/aggregation/max.py
 ##########
 @@ -0,0 +1,60 @@
+# coding=utf-8
 
 Review comment:
   Yes, these are for the [transform 
catalog](https://beam.apache.org/documentation/transforms/python/overview/), so 
even if it is very similar content, it is useful to see examples for every 
single transform and how to use them in different circumstances. We already 
have the [element-wise 
transforms](https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples/snippets/transforms/elementwise)
 completed with their docs, code samples and interactive notebooks. 
([example](https://beam.apache.org/documentation/transforms/python/elementwise/map/))
   
   We are organizing them as one file per transform, for consistency with how 
the docs are organized. I was going to add reviewers after tests passed since 
Ahmet is OOO
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 347897)
    Time Spent: 4h 20m  (was: 4h 10m)

> Colab examples for aggregation transforms (Python)
> --------------------------------------------------
>
>                 Key: BEAM-7390
>                 URL: https://issues.apache.org/jira/browse/BEAM-7390
>             Project: Beam
>          Issue Type: Improvement
>          Components: website
>            Reporter: Rose Nguyen
>            Assignee: David Cavazos
>            Priority: Minor
>          Time Spent: 4h 20m
>  Remaining Estimate: 0h
>
> Merge aggregation Colabs into the transform catalog



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to