[
https://issues.apache.org/jira/browse/BEAM-8575?focusedWorklogId=348299&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-348299
]
ASF GitHub Bot logged work on BEAM-8575:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Nov/19 19:35
Start Date: 22/Nov/19 19:35
Worklog Time Spent: 10m
Work Description: bumblebee-coming commented on pull request #10159:
[BEAM-8575] Added a unit test to CombineTest class to test that Combi…
URL: https://github.com/apache/beam/pull/10159#discussion_r349761098
##########
File path: sdks/python/apache_beam/transforms/combiners_test.py
##########
@@ -393,6 +398,18 @@ def test_global_fanout(self):
| beam.CombineGlobally(combine.MeanCombineFn()).with_fanout(11))
assert_that(result, equal_to([49.5]))
+ @attr('ValidatesRunner')
+ def test_hot_key_combining_with_accumulation_mode(self):
+ with TestPipeline() as p:
+ result = (p
+ | beam.Create([1, 2, 3, 4, 5])
+ | beam.WindowInto(GlobalWindows(),
+ trigger=Repeatedly(AfterCount(1)),
+ accumulation_mode=
+ AccumulationMode.ACCUMULATING)
+ | beam.CombineGlobally(sum).without_defaults().with_fanout(2))
Review comment:
It is really unnecessary. I followed the Java parity. I'll remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 348299)
Time Spent: 19.5h (was: 19h 20m)
> Add more Python validates runner tests
> --------------------------------------
>
> Key: BEAM-8575
> URL: https://issues.apache.org/jira/browse/BEAM-8575
> Project: Beam
> Issue Type: Test
> Components: sdk-py-core, testing
> Reporter: wendy liu
> Assignee: wendy liu
> Priority: Major
> Time Spent: 19.5h
> Remaining Estimate: 0h
>
> This is the umbrella issue to track the work of adding more Python tests to
> improve test coverage.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
