[
https://issues.apache.org/jira/browse/BEAM-8836?focusedWorklogId=350528&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-350528
]
ASF GitHub Bot logged work on BEAM-8836:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Nov/19 16:25
Start Date: 27/Nov/19 16:25
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #10229: [BEAM-8836] Make
ExternalTransform unique_name unique
URL: https://github.com/apache/beam/pull/10229#discussion_r351384985
##########
File path: sdks/python/apache_beam/transforms/external.py
##########
@@ -294,7 +294,7 @@ def expand(self, pvalueish):
else pvalueish.pipeline)
context = pipeline_context.PipelineContext()
transform_proto = beam_runner_api_pb2.PTransform(
- unique_name=self._EXPANDED_TRANSFORM_UNIQUE_NAME,
+ unique_name=pipeline._current_transform().full_label,
Review comment:
Thanks! Kind of odd we were using only `root` as the unique name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 350528)
Time Spent: 50m (was: 40m)
> ExternalTransform is not providing a unique name
> ------------------------------------------------
>
> Key: BEAM-8836
> URL: https://issues.apache.org/jira/browse/BEAM-8836
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Sam Bourne
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Using multiple ExternalTransform results in a naming collision. A simple
> pipeline example:
> A minimal reproducable example:
> Start ExpansionService/JobService:
> ./gradlew -p runners/flink/1.8/job-server runShadow
> Then run a baisc pipeline with two ExternalTransforms:
> https://gist.github.com/sambvfx/e8b08acac8ded19e86ecefaa79a8a272
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
