[
https://issues.apache.org/jira/browse/BEAM-8811?focusedWorklogId=350629&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-350629
]
ASF GitHub Bot logged work on BEAM-8811:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Nov/19 19:00
Start Date: 27/Nov/19 19:00
Worklog Time Spent: 10m
Work Description: soyrice commented on issue #10200: [BEAM-8811] Upgrade
Beam pipeline diagrams in docs
URL: https://github.com/apache/beam/pull/10200#issuecomment-559213147
> These diagrams are great! They'll definitely help users grasp concepts
more easily. I have a few overall recommendations to improve these figures:
>
> 1. Add an alt attribute to each of the images for accessibility purposes
> 2. Resize the figures so that on a given page, the font on the figures are
the same size. e.g. the sizing on "Figure: A linear pipeline with three
sequential transforms." looks appropriate, but you'll need to resize the figure
below it
I resized all of the figures that were bigger than the "linear pipeline with
three sequential transforms" one.
What do you think we should do about figures that are smaller, like the
wordcount example diagram? If I scale these diagrams up, then they're too long
to fit on the page. I was thinking of leaving them in the smaller size, but I
could also re-draw them vertically so that we could increase the size of the
font/diagram components without overflowing.
It wouldn't take too long to re-draw the diagrams vertically, but one
drawback of long, vertical diagrams is they'd take up a lot of space. Although
maybe there's a way to wrap the text around the diagram so that it fits neatly
in the page...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 350629)
Time Spent: 2h 20m (was: 2h 10m)
> Upgrade Beam pipeline diagrams in docs
> --------------------------------------
>
> Key: BEAM-8811
> URL: https://issues.apache.org/jira/browse/BEAM-8811
> Project: Beam
> Issue Type: Improvement
> Components: website
> Reporter: Cyrus Maden
> Assignee: Cyrus Maden
> Priority: Minor
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
