[
https://issues.apache.org/jira/browse/BEAM-8664?focusedWorklogId=350720&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-350720
]
ASF GitHub Bot logged work on BEAM-8664:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Nov/19 23:05
Start Date: 27/Nov/19 23:05
Worklog Time Spent: 10m
Work Description: 11moon11 commented on pull request #10095: [BEAM-8664]
[SQL] MongoDb project push down
URL: https://github.com/apache/beam/pull/10095#discussion_r351530254
##########
File path:
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/mongodb/MongoDbReadWriteIT.java
##########
@@ -187,7 +199,68 @@ public void testWriteAndRead() {
PCollection<Row> output =
BeamSqlRelUtils.toPCollection(readPipeline, sqlEnv.parseQuery("select
* from TEST"));
- assertEquals(output.getSchema(), SOURCE_SCHEMA);
+ assertEquals(SOURCE_SCHEMA, output.getSchema());
Review comment:
I agree, `assertEquals` is not very intuitive in terms of which parameter is
the expected value and which is the actual. Will change in a next commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 350720)
Time Spent: 3h 10m (was: 3h)
> [SQL] MongoDb should use project push-down
> ------------------------------------------
>
> Key: BEAM-8664
> URL: https://issues.apache.org/jira/browse/BEAM-8664
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Kirill Kozlov
> Assignee: Kirill Kozlov
> Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> MongoDbTable should implement the following methods:
> {code:java}
> public PCollection<Row> buildIOReader(
> PBegin begin, BeamSqlTableFilter filters, List<String> fieldNames);
> public ProjectSupport supportsProjects();
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
